home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 902286066

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5716#issuecomment-902286066 https://api.github.com/repos/pydata/xarray/issues/5716 902286066 IC_kwDOAMm_X841x8ry 5635139 2021-08-19T22:13:32Z 2021-08-19T22:13:32Z MEMBER

This looks good., thanks @pkopparla Thanks for reviewing @Illviljan .

Agree re a test — at least to just test it runs, albeit trivial.

FrozenDict would be better, though I think fine to do in another PR. We could return dict(OPTIONS) if we're worried people will attempt to set invalid values.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  974659059
Powered by Datasette · Queries took 0.65ms · About: xarray-datasette