issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 963239311 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Improves rendering of complex LaTeX expressions as `long_name`s when plotting · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
899945997 https://github.com/pydata/xarray/pull/5682#issuecomment-899945997 https://api.github.com/repos/pydata/xarray/issues/5682 IC_kwDOAMm_X841pBYN dcherian 2448579 2021-08-17T02:29:33Z 2021-08-17T02:29:33Z MEMBER

That's unrelated, see #5654

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improves rendering of complex LaTeX expressions as `long_name`s when plotting 963239311
899929020 https://github.com/pydata/xarray/pull/5682#issuecomment-899929020 https://api.github.com/repos/pydata/xarray/issues/5682 IC_kwDOAMm_X841o9O8 dcherian 2448579 2021-08-17T01:41:51Z 2021-08-17T01:42:08Z MEMBER

Looks great. I'll merge when tests pass.

Thanks @tomchor. I see this is your first PR here. Welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improves rendering of complex LaTeX expressions as `long_name`s when plotting 963239311
897696009 https://github.com/pydata/xarray/pull/5682#issuecomment-897696009 https://api.github.com/repos/pydata/xarray/issues/5682 IC_kwDOAMm_X841gcEJ dcherian 2448579 2021-08-12T14:39:05Z 2021-08-12T14:39:05Z MEMBER

@tomchor thanks. Yes all you need to do is define a test function that checks something and pytest will run it.

you can run it following the instructions here: https://xarray.pydata.org/en/stable/contributing.html#running-the-test-suite

(something like this) pytest xarray/tests/test_utils.py -k test_latex_name_isnt_split

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improves rendering of complex LaTeX expressions as `long_name`s when plotting 963239311
894867998 https://github.com/pydata/xarray/pull/5682#issuecomment-894867998 https://api.github.com/repos/pydata/xarray/issues/5682 IC_kwDOAMm_X841Vpoe Illviljan 14371165 2021-08-08T22:58:21Z 2021-08-08T22:58:21Z MEMBER

I wonder if it will look best if we avoid splitting inside the latex code? name, extra and units can have latex as well so I think we need to handle the entire name+extra+units string somehow.

I was playing around a little with regex but I didn't get that far: ```python import textwrap import re

name = r"$Ra_s = \mathrm{mean}(\epsilon_k) / \mu M^2_\infty$" extra = "Longwinded comments about something confusing. " units = r"$[N / m]$" label_raw = name + extra + units label_notex = re.sub("\$(.+?)\$", "X ", label_raw, flags=re.DOTALL) label_notex_wrap = textwrap.wrap(label_notex, 30) label_tex_wrap = ... # regex to add back the latex strings.
``` There might very well be a simpler way of doing this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improves rendering of complex LaTeX expressions as `long_name`s when plotting 963239311

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);