issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 945434599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Kwargs to rasterio open · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
889681208 https://github.com/pydata/xarray/pull/5609#issuecomment-889681208 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X841B3U4 keewis 14808389 2021-07-30T07:09:10Z 2021-07-30T07:09:10Z MEMBER

Thanks, @pkopparla. I also noticed this is your first PR here. Welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887381034 https://github.com/pydata/xarray/pull/5609#issuecomment-887381034 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8405Fwq keewis 14808389 2021-07-27T10:02:21Z 2021-07-27T10:02:21Z MEMBER

thanks for the update, @pkopparla. I'll merge this tomorrow if there are no further comments.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887315650 https://github.com/pydata/xarray/pull/5609#issuecomment-887315650 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X84041zC keewis 14808389 2021-07-27T08:24:34Z 2021-07-27T08:24:34Z MEMBER

no, this is fine, and the PR looks good to me. I'd say let's wait one more day to give more time for reviews and then merge by tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887286544 https://github.com/pydata/xarray/pull/5609#issuecomment-887286544 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404usQ keewis 14808389 2021-07-27T07:40:24Z 2021-07-27T07:40:24Z MEMBER

this has been fixed / worked around on main, so the merge should have fixed it

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880870712 https://github.com/pydata/xarray/pull/5609#issuecomment-880870712 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDg3MDcxMg== keewis 14808389 2021-07-15T17:10:29Z 2021-07-15T17:10:29Z MEMBER

right, it seems it's both backend_kwargs and **kwargs for open_dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880840290 https://github.com/pydata/xarray/pull/5609#issuecomment-880840290 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDg0MDI5MA== dcherian 2448579 2021-07-15T16:26:18Z 2021-07-15T16:26:18Z MEMBER

rioxarray.open_rasterio (and xr.open_zarr) uses the **kwargs format, so maybe that's the model to follow?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880812923 https://github.com/pydata/xarray/pull/5609#issuecomment-880812923 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDgxMjkyMw== keewis 14808389 2021-07-15T15:56:06Z 2021-07-15T15:56:06Z MEMBER

I would try to stay as close to open_dataset as possible, which would make migrating to rioxarray's engine easier once we deprecate open_rasterio. If I understand the signature of open_dataset correctly, this is called backend_kwargs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880783738 https://github.com/pydata/xarray/pull/5609#issuecomment-880783738 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDc4MzczOA== max-sixty 5635139 2021-07-15T15:18:48Z 2021-07-15T15:18:48Z MEMBER

Should this pass **kwargs through rather than take an explicit kwargs arg?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);