issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 937336962 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • dataset `__repr__` updates · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
903185411 https://github.com/pydata/xarray/pull/5580#issuecomment-903185411 https://api.github.com/repos/pydata/xarray/issues/5580 IC_kwDOAMm_X8411YQD max-sixty 5635139 2021-08-21T22:51:16Z 2021-08-21T22:51:16Z MEMBER

@st-bender thank you very much! Great to have you as a contributor

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset `__repr__` updates 937336962
881056480 https://github.com/pydata/xarray/pull/5580#issuecomment-881056480 https://api.github.com/repos/pydata/xarray/issues/5580 MDEyOklzc3VlQ29tbWVudDg4MTA1NjQ4MA== max-sixty 5635139 2021-07-15T22:43:03Z 2021-07-15T22:43:03Z MEMBER

As for the tests, I found the tests that @max-sixty put in and extended them (see second and third commits in this PR). However, now there is one dataset setup and then 4(!) asserts, which seems to be too much to follow nicely. Imagine all of them break, you fix the first, only to find out that the second breaks as well. so you fix that, only to find out that the third breaks too, and so on.

I very much empathize! It was basically this frustration that drove me to writing that pytest-accept plugin. If you'd like to do these as doctests, that is fine too — whatever you think is best.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset `__repr__` updates 937336962
874449093 https://github.com/pydata/xarray/pull/5580#issuecomment-874449093 https://api.github.com/repos/pydata/xarray/issues/5580 MDEyOklzc3VlQ29tbWVudDg3NDQ0OTA5Mw== max-sixty 5635139 2021-07-06T04:25:06Z 2021-07-06T04:25:06Z MEMBER

This looks good! Thanks @st-bender .

Could we add a short note on the change to the whatsnew? To the extent the existing docs on the repr are now out of date, could we update those too?

Then we're good to merge! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset `__repr__` updates 937336962

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);