issue_comments: 881056480

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5580#issuecomment-881056480 https://api.github.com/repos/pydata/xarray/issues/5580 881056480 MDEyOklzc3VlQ29tbWVudDg4MTA1NjQ4MA== 5635139 2021-07-15T22:43:03Z 2021-07-15T22:43:03Z MEMBER

As for the tests, I found the tests that @max-sixty put in and extended them (see second and third commits in this PR). However, now there is one dataset setup and then 4(!) asserts, which seems to be too much to follow nicely. Imagine all of them break, you fix the first, only to find out that the second breaks as well. so you fix that, only to find out that the third breaks too, and so on.

I very much empathize! It was basically this frustration that drove me to writing that pytest-accept plugin. If you'd like to do these as doctests, that is fine too — whatever you think is best.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   937336962