issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 863506023 and user = 6815844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • fujiisoup · 6 ✖

issue 1

  • Fix lag in Jupyter caused by CSS in `_repr_html_` · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
872042733 https://github.com/pydata/xarray/pull/5201#issuecomment-872042733 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MjA0MjczMw== fujiisoup 6815844 2021-07-01T08:31:46Z 2021-07-01T08:31:46Z MEMBER

Maybe a Jupyter issue and not related to libraries in use?

I see. Indeed, I didn't see any significant difference among branches.

I may be able later today when I am back to my main computer

I tried but I think maybe better to wait for your update.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
872033015 https://github.com/pydata/xarray/pull/5201#issuecomment-872033015 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MjAzMzAxNQ== fujiisoup 6815844 2021-07-01T08:18:55Z 2021-07-01T08:18:55Z MEMBER

Maybe can we measure the first-loading time? I observe the first-loading time is very long... (movie)

The only way I was able to see it was to use the Web Dev tools that come as part of Firefox or Chrome.

Can you tell me more about this? I'll try to reproduce and measure the performance.

https://user-images.githubusercontent.com/6815844/124090964-4e601e80-da90-11eb-8333-7c2a25a8f33d.mp4

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
872007738 https://github.com/pydata/xarray/pull/5201#issuecomment-872007738 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MjAwNzczOA== fujiisoup 6815844 2021-07-01T07:45:01Z 2021-07-01T07:45:01Z MEMBER

did you try if there are differences when running an individual cell, not just when loading the page the first time?

I tried to measure the performance by running all the cells as shown in the image but I could not find any significant difference.

However, I'm not very confident if this actually measures the css performance.

@SimonHeybrock, do you have any suggestions how to measure the peformance?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
871748248 https://github.com/pydata/xarray/pull/5201#issuecomment-871748248 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDg3MTc0ODI0OA== fujiisoup 6815844 2021-06-30T21:45:52Z 2021-06-30T21:45:52Z MEMBER

I am trying to measure the performance of master, this PR and mine (which fixes this PR to be compatible with dark mode) but couldn't see any big difference in my environment.

What I did in this experiment is to make a notebook with hundreds of empty cells with xarray under these branches. Refreshed the browser to render the htmls. Number of cells are the same in all these experiments, but only the xarray branches (and produced html) are different.

Maybe we may need more cells? Any advice would be appreciated.

https://user-images.githubusercontent.com/6815844/124035536-9ef75d80-da37-11eb-9c78-a9c76d16da1a.mp4

movie top left: this branch top right: mine bottom left: master

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828794224 https://github.com/pydata/xarray/pull/5201#issuecomment-828794224 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODc5NDIyNA== fujiisoup 6815844 2021-04-28T21:33:06Z 2021-04-28T21:33:06Z MEMBER

This

https://github.com/fujiisoup/xarray/blob/6225f158626e75977a0a944fbc09c50769884e35/xarray/static/css/style.css#L5-L29

looks working with a darkmode, but I'm not sure if this solves the original problem.

It looks to me that defining custom properties in html[theme=dark] may cause the same problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023
828778799 https://github.com/pydata/xarray/pull/5201#issuecomment-828778799 https://api.github.com/repos/pydata/xarray/issues/5201 MDEyOklzc3VlQ29tbWVudDgyODc3ODc5OQ== fujiisoup 6815844 2021-04-28T21:03:50Z 2021-04-28T21:03:50Z MEMBER

Confirmed that this also breaks the darkmode also in google colab.

@fujiisoup added the vscode dark mode support, maybe he has ideas.

I did it in #4036 but this was actually a workaround and should be improved by an expert. I'll take a look, but with little hope to fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix lag in Jupyter caused by CSS in `_repr_html_` 863506023

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);