home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 871748248

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5201#issuecomment-871748248 https://api.github.com/repos/pydata/xarray/issues/5201 871748248 MDEyOklzc3VlQ29tbWVudDg3MTc0ODI0OA== 6815844 2021-06-30T21:45:52Z 2021-06-30T21:45:52Z MEMBER

I am trying to measure the performance of master, this PR and mine (which fixes this PR to be compatible with dark mode) but couldn't see any big difference in my environment.

What I did in this experiment is to make a notebook with hundreds of empty cells with xarray under these branches. Refreshed the browser to render the htmls. Number of cells are the same in all these experiments, but only the xarray branches (and produced html) are different.

Maybe we may need more cells? Any advice would be appreciated.

https://user-images.githubusercontent.com/6815844/124035536-9ef75d80-da37-11eb-9c78-a9c76d16da1a.mp4

movie top left: this branch top right: mine bottom left: master

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  863506023
Powered by Datasette · Queries took 0.797ms · About: xarray-datasette