issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 853644364 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Fix open_dataset regression · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
820374206 https://github.com/pydata/xarray/pull/5135#issuecomment-820374206 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgyMDM3NDIwNg== alexamici 226037 2021-04-15T12:11:26Z 2021-04-15T12:11:26Z MEMBER

@bcbnz thanks for the help! I'll merge it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
818806507 https://github.com/pydata/xarray/pull/5135#issuecomment-818806507 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxODgwNjUwNw== keewis 14808389 2021-04-13T15:01:27Z 2021-04-13T15:01:27Z MEMBER

@alexamici, that's #5147

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
818804036 https://github.com/pydata/xarray/pull/5135#issuecomment-818804036 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxODgwNDAzNg== alexamici 226037 2021-04-13T14:58:07Z 2021-04-13T14:58:07Z MEMBER

@aurghs can you confirm that all failures are unrelated to the changes?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816027472 https://github.com/pydata/xarray/pull/5135#issuecomment-816027472 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAyNzQ3Mg== alexamici 226037 2021-04-08T18:03:14Z 2021-04-08T18:03:14Z MEMBER

@aurghs you may also use _normalize_path that does all the checks:

https://github.com/pydata/xarray/blob/master/xarray/backends/api.py#L112

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816019678 https://github.com/pydata/xarray/pull/5135#issuecomment-816019678 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAxOTY3OA== alexamici 226037 2021-04-08T17:50:25Z 2021-04-08T17:54:36Z MEMBER

@aurghs & @dcherian note that at the moment most backends accept pathlib.Path (but it is not tested), so the isintance(..., str) doesn't run expanduser in that case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364
816013551 https://github.com/pydata/xarray/pull/5135#issuecomment-816013551 https://api.github.com/repos/pydata/xarray/issues/5135 MDEyOklzc3VlQ29tbWVudDgxNjAxMzU1MQ== dcherian 2448579 2021-04-08T17:40:34Z 2021-04-08T17:40:34Z MEMBER

LGTM. I don't know how we would test this...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix open_dataset regression 853644364

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);