issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 830918156 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • max-sixty · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
827364568 https://github.com/pydata/xarray/pull/5031#issuecomment-827364568 https://api.github.com/repos/pydata/xarray/issues/5031 MDEyOklzc3VlQ29tbWVudDgyNzM2NDU2OA== max-sixty 5635139 2021-04-27T07:00:15Z 2021-04-27T07:00:15Z MEMBER

Many thanks @Illviljan !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep coord attrs when interpolating 830918156
827364451 https://github.com/pydata/xarray/pull/5031#issuecomment-827364451 https://api.github.com/repos/pydata/xarray/issues/5031 MDEyOklzc3VlQ29tbWVudDgyNzM2NDQ1MQ== max-sixty 5635139 2021-04-27T07:00:00Z 2021-04-27T07:00:00Z MEMBER

Merging given previous approvals — we can handle any other concerns in a future PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep coord attrs when interpolating 830918156
822053610 https://github.com/pydata/xarray/pull/5031#issuecomment-822053610 https://api.github.com/repos/pydata/xarray/issues/5031 MDEyOklzc3VlQ29tbWVudDgyMjA1MzYxMA== max-sixty 5635139 2021-04-18T20:13:09Z 2021-04-18T20:13:09Z MEMBER

Sorry for the recent slow-down in reviews @Illviljan , and thank you for your recent PRs. I'm going to suggest we find a more robust system for ensuring PRs get prompt reviews in our next dev meeting.

Are people OK to merge this? While it brings up some broader issues, as long as this change doesn't cause those issues to be harder to resolve, this behavior seems good, as described by @dcherian :

I think copying over ds.coords["x"].attrs for ds.interp(x=[1,2,3]) is sensible.

(But I've been less involved in the details of attrs, so please tell me if this is rushing through narrower changes rather than addressing them more broadly)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep coord attrs when interpolating 830918156
798972546 https://github.com/pydata/xarray/pull/5031#issuecomment-798972546 https://api.github.com/repos/pydata/xarray/issues/5031 MDEyOklzc3VlQ29tbWVudDc5ODk3MjU0Ng== max-sixty 5635139 2021-03-14T20:17:44Z 2021-03-14T20:17:44Z MEMBER

Looks good! Would you like to add a whatsnew entry @Illviljan ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep coord attrs when interpolating 830918156

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);