home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 822053610

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5031#issuecomment-822053610 https://api.github.com/repos/pydata/xarray/issues/5031 822053610 MDEyOklzc3VlQ29tbWVudDgyMjA1MzYxMA== 5635139 2021-04-18T20:13:09Z 2021-04-18T20:13:09Z MEMBER

Sorry for the recent slow-down in reviews @Illviljan , and thank you for your recent PRs. I'm going to suggest we find a more robust system for ensuring PRs get prompt reviews in our next dev meeting.

Are people OK to merge this? While it brings up some broader issues, as long as this change doesn't cause those issues to be harder to resolve, this behavior seems good, as described by @dcherian :

I think copying over ds.coords["x"].attrs for ds.interp(x=[1,2,3]) is sensible.

(But I've been less involved in the details of attrs, so please tell me if this is rushing through narrower changes rather than addressing them more broadly)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  830918156
Powered by Datasette · Queries took 79.59ms · About: xarray-datasette