issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 819897789 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Date missing in datetime accessor · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
791089119 https://github.com/pydata/xarray/issues/4983#issuecomment-791089119 https://api.github.com/repos/pydata/xarray/issues/4983 MDEyOklzc3VlQ29tbWVudDc5MTA4OTExOQ== spencerkclark 6628425 2021-03-05T02:01:23Z 2021-03-05T02:01:23Z MEMBER

For sure, thanks for getting started on a PR! I like the more informative AttributeError you added; I agree the existing error for the time attribute is difficult to follow. Let me know when it is ready for review.

Regarding da.time.dt.floor("D"), we could also consider adding a normalize method (e.g. in pandas) which is shorthand for the same thing. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Date missing in datetime accessor 819897789
789275247 https://github.com/pydata/xarray/issues/4983#issuecomment-789275247 https://api.github.com/repos/pydata/xarray/issues/4983 MDEyOklzc3VlQ29tbWVudDc4OTI3NTI0Nw== spencerkclark 6628425 2021-03-02T22:38:50Z 2021-03-02T22:38:50Z MEMBER

Yes, I agree, this seems reasonable. It's true that there is no object equivalent to datetime.date in cftime, but I do not think that is necessarily a requirement. We can raise an error in that instance.

I'll admit I personally have not found a need for functionality like this -- I typically prefer to use something like da.time.dt.floor("D"), since it retains the np.datetime64 or cftime type -- but if folks would find it useful I think it makes sense to add (this has come up on StackOverflow before too).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Date missing in datetime accessor 819897789
789033264 https://github.com/pydata/xarray/issues/4983#issuecomment-789033264 https://api.github.com/repos/pydata/xarray/issues/4983 MDEyOklzc3VlQ29tbWVudDc4OTAzMzI2NA== mathause 10194086 2021-03-02T16:26:31Z 2021-03-02T16:26:31Z MEMBER

Sounds reasonable. Or maybe that's not supported in cftime? cc @spencerkclark 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Date missing in datetime accessor 819897789

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);