issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 789410367 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Reading and writing a zarr dataset multiple times casts bools to int8 · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1498799474 https://github.com/pydata/xarray/issues/4826#issuecomment-1498799474 https://api.github.com/repos/pydata/xarray/issues/4826 IC_kwDOAMm_X85ZVd1y kmuehlbauer 5821660 2023-04-06T09:59:42Z 2023-04-06T09:59:42Z MEMBER

@JoerivanEngelen Thanks for taking the time. Much appreciated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reading and writing a zarr dataset multiple times casts bools to int8 789410367
1497971459 https://github.com/pydata/xarray/issues/4826#issuecomment-1497971459 https://api.github.com/repos/pydata/xarray/issues/4826 IC_kwDOAMm_X85ZSTsD kmuehlbauer 5821660 2023-04-05T18:56:23Z 2023-04-05T18:56:23Z MEMBER

Please check #7720 if that fixes the conversion problems. Thanks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reading and writing a zarr dataset multiple times casts bools to int8 789410367
822893203 https://github.com/pydata/xarray/issues/4826#issuecomment-822893203 https://api.github.com/repos/pydata/xarray/issues/4826 MDEyOklzc3VlQ29tbWVudDgyMjg5MzIwMw== andersy005 13301940 2021-04-20T01:01:46Z 2021-04-20T01:03:23Z MEMBER

I think this issue is related to #2937.

This is the same problem reported in https://github.com/pydata/xarray/issues/4386. All these issues (#2937, #4826, #4386, #5192) should be closable once there's a fix. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reading and writing a zarr dataset multiple times casts bools to int8 789410367
780912328 https://github.com/pydata/xarray/issues/4826#issuecomment-780912328 https://api.github.com/repos/pydata/xarray/issues/4826 MDEyOklzc3VlQ29tbWVudDc4MDkxMjMyOA== shoyer 1217238 2021-02-17T23:04:03Z 2021-02-17T23:04:03Z MEMBER

There are at least two issues here:

  • For both netCDF and zarr, we should definitely "round trip" preserve dtypes. There are a few ways this might be done. I would have to look at a PR to say for sure, but from the looks of it "Change maybe_encode_bool to not ignore when .encoding["dtype"] exists" is the right fix.
  • Zarr supports bool data, so we don't need conversion from bool -> int8. We should just save data as bool.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reading and writing a zarr dataset multiple times casts bools to int8 789410367

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);