issue_comments: 780912328

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4826#issuecomment-780912328 https://api.github.com/repos/pydata/xarray/issues/4826 780912328 MDEyOklzc3VlQ29tbWVudDc4MDkxMjMyOA== 1217238 2021-02-17T23:04:03Z 2021-02-17T23:04:03Z MEMBER

There are at least two issues here:

  • For both netCDF and zarr, we should definitely "round trip" preserve dtypes. There are a few ways this might be done. I would have to look at a PR to say for sure, but from the looks of it "Change maybe_encode_bool to not ignore when .encoding["dtype"] exists" is the right fix.
  • Zarr supports bool data, so we don't need conversion from bool -> int8. We should just save data as bool.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   789410367