issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 703550109 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

issue 1

  • Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
697933542 https://github.com/pydata/xarray/pull/4431#issuecomment-697933542 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5NzkzMzU0Mg== shoyer 1217238 2020-09-23T19:44:46Z 2020-09-23T19:44:46Z MEMBER

@jhamman I don't understand why 4f414f2 is shown here, it is a commit in master.

I usually find it easiest just to use "merge master" to integrate the latest changes, and to treat pull requests as "append only". History gets consolidated/rewritten when we merge the PR with "Squash and Merge"

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
697924785 https://github.com/pydata/xarray/pull/4431#issuecomment-697924785 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5NzkyNDc4NQ== alexamici 226037 2020-09-23T19:26:44Z 2020-09-23T19:26:44Z MEMBER

@jhamman I don't understand why 4f414f2 is shown here, it is a commit in master.

As for the rest, we re applied the engine selection refactor and added the new zarr bits.

All looks reasonable to me and all tests pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
696970366 https://github.com/pydata/xarray/pull/4431#issuecomment-696970366 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5Njk3MDM2Ng== alexamici 226037 2020-09-22T20:45:53Z 2020-09-22T20:45:53Z MEMBER

Thanks @keewis! So it is correct, I wanted to reset to master and re apply the changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
696963578 https://github.com/pydata/xarray/pull/4431#issuecomment-696963578 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5Njk2MzU3OA== keewis 14808389 2020-09-22T20:32:37Z 2020-09-22T20:32:37Z MEMBER

the reason the PR was closed is that you removed the changes, so the diff to master is empty. I think you can reopen after pushing commits with changes.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
696960812 https://github.com/pydata/xarray/pull/4431#issuecomment-696960812 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5Njk2MDgxMg== alexamici 226037 2020-09-22T20:27:02Z 2020-09-22T20:27:02Z MEMBER

Woops I didn't know that force pushing a branch would close the PR :/

I'll try to reopen this PR or create a new one. Sorry for the noise.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
696518718 https://github.com/pydata/xarray/pull/4431#issuecomment-696518718 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5NjUxODcxOA== shoyer 1217238 2020-09-22T05:41:44Z 2020-09-22T05:41:44Z MEMBER

https://github.com/pydata/xarray/pull/4187 has been merged, so this can go ahead again!

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
694539990 https://github.com/pydata/xarray/pull/4431#issuecomment-694539990 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5NDUzOTk5MA== jhamman 2443309 2020-09-17T22:46:47Z 2020-09-17T22:46:47Z MEMBER

Thanks for the ping @alexamici - this looks good to me. Happy to see this merged once we sort out the conflicts in #4187.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109
694411881 https://github.com/pydata/xarray/pull/4431#issuecomment-694411881 https://api.github.com/repos/pydata/xarray/issues/4431 MDEyOklzc3VlQ29tbWVudDY5NDQxMTg4MQ== alexamici 226037 2020-09-17T18:16:53Z 2020-09-17T18:17:14Z MEMBER

@jhamman: @shoyer requested to keep this PR on hold until #4187 is merged as it will produce conflicts.

So I converted the PR to draft, after #4187 gets in, we will fix the conflicts and resubmit.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 703550109

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);