home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 703550109

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
703550109 MDExOlB1bGxSZXF1ZXN0NDg4NjM5MDYy 4431 Refactor of the big if-chain to a dictionary in the form {backend_name: backend_open}. 226037 closed 0     9 2020-09-17T12:39:55Z 2020-12-10T10:30:40Z 2020-09-24T15:03:46Z MEMBER   0 pydata/xarray/pulls/4431

This ports the clean up of the messy if-else-chain from #3166. It should make adding the new back-end API easier.

The change is relatively trivial, but it touches code in xr.open_dataset so extra care should be used by reviewers. We think the change is safe and it does pass all tests.

  • [x] Port the generic part of #3166
  • [x] Tests sync'ed
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] No user visible change
  • [x] No new functions/methods

I cannot add reviewers myself, but we agreed this should go to @jhamman.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4431/reactions",
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 2 rows from issues_id in issues_labels
  • 9 rows from issue in issue_comments
Powered by Datasette · Queries took 0.506ms · About: xarray-datasette