issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 683954433 and user = 14371165 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • Illviljan · 3 ✖

issue 1

  • Should __repr__ and __str__ be PEP8 compliant? · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
678738626 https://github.com/pydata/xarray/issues/4367#issuecomment-678738626 https://api.github.com/repos/pydata/xarray/issues/4367 MDEyOklzc3VlQ29tbWVudDY3ODczODYyNg== Illviljan 14371165 2020-08-23T07:10:26Z 2020-08-23T07:10:26Z MEMBER

Pandas breaks PEP8 (80 > 79) too then and Numpy is PEP8 compliant to one indent level (75 + 4) which I think is fine.

I see no point in temporarily changing settings as it will not work with doctest. I will work around it by printing numpy arrays instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should __repr__ and __str__ be PEP8 compliant? 683954433
678700741 https://github.com/pydata/xarray/issues/4367#issuecomment-678700741 https://api.github.com/repos/pydata/xarray/issues/4367 MDEyOklzc3VlQ29tbWVudDY3ODcwMDc0MQ== Illviljan 14371165 2020-08-22T22:06:26Z 2020-08-22T22:06:26Z MEMBER

Black defaults to 88 characters per line, which happens to be 10% over 80. This number was found to produce significantly shorter files than sticking with 80 (the most popular), or even 79 (used by the standard library). https://black.readthedocs.io/en/stable/the_black_code_style.html

I wonder why they don't reduce the indent size too if minimizing rows is of such importance.

The line width does make perfect sense if Black is the new de facto standard. I don't think it's the path of least resistance though. If 88 is used it will trigger other code style analyzers (it did for me) because they default to 79. PEP8 has been around for 19 years, black has a lot of work trying to persuade 19 years of people recommending following PEP8.

Have you updated the pep8speaks bot with this line length?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should __repr__ and __str__ be PEP8 compliant? 683954433
678619316 https://github.com/pydata/xarray/issues/4367#issuecomment-678619316 https://api.github.com/repos/pydata/xarray/issues/4367 MDEyOklzc3VlQ29tbWVudDY3ODYxOTMxNg== Illviljan 14371165 2020-08-22T09:35:12Z 2020-08-22T09:39:14Z MEMBER

Seems the max width is defined in https://github.com/pydata/xarray/blob/43a2a4bdf3a492d89aae9f2c5b0867932ff51cef/xarray/core/options.py. Setting OPTIONS[DISPLAY_WIDTH] = 71 does the trick. Not sure where else this option is used though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should __repr__ and __str__ be PEP8 compliant? 683954433

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);