home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 678700741

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4367#issuecomment-678700741 https://api.github.com/repos/pydata/xarray/issues/4367 678700741 MDEyOklzc3VlQ29tbWVudDY3ODcwMDc0MQ== 14371165 2020-08-22T22:06:26Z 2020-08-22T22:06:26Z MEMBER

Black defaults to 88 characters per line, which happens to be 10% over 80. This number was found to produce significantly shorter files than sticking with 80 (the most popular), or even 79 (used by the standard library). https://black.readthedocs.io/en/stable/the_black_code_style.html

I wonder why they don't reduce the indent size too if minimizing rows is of such importance.

The line width does make perfect sense if Black is the new de facto standard. I don't think it's the path of least resistance though. If 88 is used it will trigger other code style analyzers (it did for me) because they default to 79. PEP8 has been around for 19 years, black has a lot of work trying to persuade 19 years of people recommending following PEP8.

Have you updated the pep8speaks bot with this line length?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  683954433
Powered by Datasette · Queries took 1.163ms · About: xarray-datasette