issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 658938729 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mathause · 5 ✖

issue 1

  • Linear interp with NaNs in nd indexer · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
681812005 https://github.com/pydata/xarray/pull/4233#issuecomment-681812005 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY4MTgxMjAwNQ== mathause 10194086 2020-08-27T08:50:15Z 2020-08-27T08:50:15Z MEMBER

thanks @jenssss I see this is your first PR - welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679967683 https://github.com/pydata/xarray/pull/4233#issuecomment-679967683 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTk2NzY4Mw== mathause 10194086 2020-08-25T11:27:33Z 2020-08-25T11:28:31Z MEMBER

LGTM. I'll merge in a day or two unless someone else has a comment. (#3924)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679911389 https://github.com/pydata/xarray/pull/4233#issuecomment-679911389 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTkxMTM4OQ== mathause 10194086 2020-08-25T09:22:27Z 2020-08-25T09:22:27Z MEMBER

Thanks! I have two more suggestions:

Can you add an additional line with python (["2000-01-01T12:00", "2000-01-02T12:00", "NaT"], [0.5, 1.5]), here:

https://github.com/pydata/xarray/blob/8313c3eb7e92c15a82a3ae8ba7dff7d49a37c309/xarray/tests/test_interp.py#L575

to have a test with a missing datetime.

Do you also want to add a note to the docstring, e.g. adding Missing values are skipped. Here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1425 here: https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1495

Does it also work for DataSets? Then maybe add to the docstring here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataset.py#L2603

and here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataset.py#L2731

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679327397 https://github.com/pydata/xarray/pull/4233#issuecomment-679327397 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTMyNzM5Nw== mathause 10194086 2020-08-24T19:42:16Z 2020-08-24T19:42:16Z MEMBER

I misremembered the behavior of the old np.min with datetimes - see this comment: https://github.com/pydata/xarray/pull/3924/files#discussion_r407101544

Sorry for sending you down the wrong path. I can have another look tomorrow. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678920617 https://github.com/pydata/xarray/pull/4233#issuecomment-678920617 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODkyMDYxNw== mathause 10194086 2020-08-24T05:59:47Z 2020-08-24T05:59:47Z MEMBER

Looks good - if you want to go a step further you can probably do something along the lines of (untested):

python if new_x.dtype in "mM" and LooseVersion(np.__version__) < LooseVersion("1.18") and new_x.isnull().any(): raise ValueError("numpy 1.18 or newer required to use interp with datetime/ timedelta array containing missing values") else: imin = ... np.nanmin(...) imax = ...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);