issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 657792526 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • provide set_option `collapse_html` to control HTML repr collapsed state · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
667622174 https://github.com/pydata/xarray/pull/4230#issuecomment-667622174 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY2NzYyMjE3NA== shoyer 1217238 2020-08-02T03:45:40Z 2020-08-02T03:45:40Z MEMBER

The scope is limited enough here that it would be fine to include the cleanup in this PR. The bigger issue is that names exposed in a public API need to be chosen much more carefully than internal only names — and we definitely don’t want to expose the current poorly chosen internal name for this feature to users.

On Sat, Aug 1, 2020 at 7:32 PM Michael Aye notifications@github.com wrote:

i'm fine in fixing the name of the variable, but usually open source teams don't want a PR that addresses more than one issue at a time, are you sure you want it in here?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/4230#issuecomment-667615325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVTTULSMPGZWCUNIGPTR6TF4LANCNFSM4O3LS7JA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526
667601315 https://github.com/pydata/xarray/pull/4230#issuecomment-667601315 https://api.github.com/repos/pydata/xarray/issues/4230 MDEyOklzc3VlQ29tbWVudDY2NzYwMTMxNQ== shoyer 1217238 2020-08-01T23:48:07Z 2020-08-01T23:48:07Z MEMBER

I support adding an option for this, but I think a name like html_expand_data or html_collapse_data would be more descriptive, because this refer specifically to the "data" section of HTML reprs.

I also agree with @jsignell that the current naming seems to be reversed "expanded" should mean show the data section and "collapsed" should mean hiding it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide set_option `collapse_html` to control HTML repr collapsed state 657792526

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);