issue_comments: 667622174

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4230#issuecomment-667622174 https://api.github.com/repos/pydata/xarray/issues/4230 667622174 MDEyOklzc3VlQ29tbWVudDY2NzYyMjE3NA== 1217238 2020-08-02T03:45:40Z 2020-08-02T03:45:40Z MEMBER

The scope is limited enough here that it would be fine to include the cleanup in this PR. The bigger issue is that names exposed in a public API need to be chosen much more carefully than internal only names — and we definitely don’t want to expose the current poorly chosen internal name for this feature to users.

On Sat, Aug 1, 2020 at 7:32 PM Michael Aye notifications@github.com wrote:

i'm fine in fixing the name of the variable, but usually open source teams don't want a PR that addresses more than one issue at a time, are you sure you want it in here?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/4230#issuecomment-667615325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVTTULSMPGZWCUNIGPTR6TF4LANCNFSM4O3LS7JA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   657792526