issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 638211949 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • signature in accessor methods · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
671652267 https://github.com/pydata/xarray/issues/4152#issuecomment-671652267 https://api.github.com/repos/pydata/xarray/issues/4152 MDEyOklzc3VlQ29tbWVudDY3MTY1MjI2Nw== keewis 14808389 2020-08-11T00:14:54Z 2020-08-11T00:14:54Z MEMBER

the issue is that we use functools.wraps to copy __doc__, __name__ and __qualname__ to newplotfunc. How about using ```python # Build on the original docstring dummy.doc = f"{plotfunc.doc}\n{commondoc}"

# to shorten the signature
@functools.wraps(plotfunc)
def dummy(darray, x, y, **kwargs):
     pass

# use the signature of dummy
del dummy.__wrapped__

@functools.wraps(dummy)
def newplotfunc(

``` instead of https://github.com/pydata/xarray/blob/1791c3b6f9852edca977c68c0bf52ed4406ef7b0/xarray/plot/plot.py#L572-L576

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   signature in accessor methods 638211949
671118697 https://github.com/pydata/xarray/issues/4152#issuecomment-671118697 https://api.github.com/repos/pydata/xarray/issues/4152 MDEyOklzc3VlQ29tbWVudDY3MTExODY5Nw== keewis 14808389 2020-08-10T00:12:18Z 2020-08-10T00:12:18Z MEMBER

unfortunately, sphinx-autosummary-accessors can't fix all of this: some of the plotting functions have a signature of (x, y, z, ax, **kwargs). After passing through the autosummary / autodoc, this becomes (y, z, ax, **kwargs) (x was assumed to be self or darray). However, this doesn't match the documentation which claims to have darray, x, y and ax instead. Maybe we should try to fix that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   signature in accessor methods 638211949
653817637 https://github.com/pydata/xarray/issues/4152#issuecomment-653817637 https://api.github.com/repos/pydata/xarray/issues/4152 MDEyOklzc3VlQ29tbWVudDY1MzgxNzYzNw== keewis 14808389 2020-07-04T22:07:52Z 2020-07-04T22:08:15Z MEMBER

actually, it seems RTD unpinned the dependency versions (not sure when they did that) so we might even be able to make use of the hack. So: should we try using that package by installing from github, or would it be better to wait until there's a released version available?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   signature in accessor methods 638211949
653598725 https://github.com/pydata/xarray/issues/4152#issuecomment-653598725 https://api.github.com/repos/pydata/xarray/issues/4152 MDEyOklzc3VlQ29tbWVudDY1MzU5ODcyNQ== keewis 14808389 2020-07-03T15:33:05Z 2020-07-03T16:56:43Z MEMBER

I hacked around that issue in the PR so this issue would be fixed by switching to sphinx-autosummary-accessors. However, since RTD pins us to sphinx=1.8.5 (we can't change that when using conda) and the way the hack is written right now requires sphinx>=3.1, we won't be able to use it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   signature in accessor methods 638211949
653135292 https://github.com/pydata/xarray/issues/4152#issuecomment-653135292 https://api.github.com/repos/pydata/xarray/issues/4152 MDEyOklzc3VlQ29tbWVudDY1MzEzNTI5Mg== keewis 14808389 2020-07-02T17:32:31Z 2020-07-02T17:32:31Z MEMBER

it seems fixing both the signature and the summary is a bit more involved than I thought and probably either requires changes to sphinx or partially rewriting the Autosummary class. Since using sphinx-autosummary-accessors will probably be the way to go here, let's continue that discussion in keewis/sphinx-autosummary-accessors#6

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   signature in accessor methods 638211949

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);