home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 671652267

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4152#issuecomment-671652267 https://api.github.com/repos/pydata/xarray/issues/4152 671652267 MDEyOklzc3VlQ29tbWVudDY3MTY1MjI2Nw== 14808389 2020-08-11T00:14:54Z 2020-08-11T00:14:54Z MEMBER

the issue is that we use functools.wraps to copy __doc__, __name__ and __qualname__ to newplotfunc. How about using ```python # Build on the original docstring dummy.doc = f"{plotfunc.doc}\n{commondoc}"

# to shorten the signature
@functools.wraps(plotfunc)
def dummy(darray, x, y, **kwargs):
     pass

# use the signature of dummy
del dummy.__wrapped__

@functools.wraps(dummy)
def newplotfunc(

``` instead of https://github.com/pydata/xarray/blob/1791c3b6f9852edca977c68c0bf52ed4406ef7b0/xarray/plot/plot.py#L572-L576

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  638211949
Powered by Datasette · Queries took 0.629ms · About: xarray-datasette