issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 59799656 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • test failures on Windows 7 OS · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
82511264 https://github.com/pydata/xarray/issues/360#issuecomment-82511264 https://api.github.com/repos/pydata/xarray/issues/360 MDEyOklzc3VlQ29tbWVudDgyNTExMjY0 shoyer 1217238 2015-03-17T18:28:12Z 2015-03-17T18:28:12Z MEMBER

I added integration testing with Appveyor on Windows and was able to fix the last few failing tests. So everything should be working now on master and will be checked automatically with every future change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test failures on Windows 7 OS 59799656
77948118 https://github.com/pydata/xarray/issues/360#issuecomment-77948118 https://api.github.com/repos/pydata/xarray/issues/360 MDEyOklzc3VlQ29tbWVudDc3OTQ4MTE4 shoyer 1217238 2015-03-09T21:34:59Z 2015-03-09T21:34:59Z MEMBER

OK, I think everything should be working on master now. For what it's worth, these were mostly testing issues -- I didn't turn up any Windows specific bugs, though there was https://github.com/xray/xray/issues/341 (related to using the scipy.io.netcdf backend).

@breisfeld any chance you'd be up for testing this out again? pip install https://github.com/xray/xray/archive/master.zip should do it.

I can also try to get appveyor setup to run continuous testing on Windows.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test failures on Windows 7 OS 59799656
77626116 https://github.com/pydata/xarray/issues/360#issuecomment-77626116 https://api.github.com/repos/pydata/xarray/issues/360 MDEyOklzc3VlQ29tbWVudDc3NjI2MTE2 shoyer 1217238 2015-03-06T20:05:26Z 2015-03-06T20:05:26Z MEMBER

I think I should be able to fix most of these pretty straightforwardly. Most of the OS errors are because we aren't closing files that we really should close.

Here's one question that I'm not quite sure about, though -- if open_dataset fails for some reason after opening a file should it ensure that any files it opened are closed? I suppose the answer is probably yes. This will be a difficult to test, though (at least on Unix machines).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test failures on Windows 7 OS 59799656
77217514 https://github.com/pydata/xarray/issues/360#issuecomment-77217514 https://api.github.com/repos/pydata/xarray/issues/360 MDEyOklzc3VlQ29tbWVudDc3MjE3NTE0 shoyer 1217238 2015-03-04T18:37:41Z 2015-03-04T18:37:41Z MEMBER

Thanks for the report! As you can probably tell, we have not tried xray on windows before.

I notice at least two issues: - os.remove failures -- might be related to https://github.com/xray/xray/issues/341 - int32 vs int64 discrepancies -- this we can definitely fix (it's because numpy on windows uses int as an alias for int32, unlike every other platform)

Can you try installing netCDF4-python (conda install netcdf4) and let me know if you get new or different errors?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test failures on Windows 7 OS 59799656

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);