home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 77626116

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/360#issuecomment-77626116 https://api.github.com/repos/pydata/xarray/issues/360 77626116 MDEyOklzc3VlQ29tbWVudDc3NjI2MTE2 1217238 2015-03-06T20:05:26Z 2015-03-06T20:05:26Z MEMBER

I think I should be able to fix most of these pretty straightforwardly. Most of the OS errors are because we aren't closing files that we really should close.

Here's one question that I'm not quite sure about, though -- if open_dataset fails for some reason after opening a file should it ensure that any files it opened are closed? I suppose the answer is probably yes. This will be a difficult to test, though (at least on Unix machines).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  59799656
Powered by Datasette · Queries took 0.767ms · About: xarray-datasette