issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 592331420 and user = 35968931 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • TomNicholas · 3 ✖

issue 1

  • Remove old auto combine · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
611372701 https://github.com/pydata/xarray/pull/3926#issuecomment-611372701 https://api.github.com/repos/pydata/xarray/issues/3926 MDEyOklzc3VlQ29tbWVudDYxMTM3MjcwMQ== TomNicholas 35968931 2020-04-09T07:19:34Z 2020-04-09T07:19:34Z MEMBER

Just noticed there's a section of the API reference for Deprecated/Pending Deprecation, but auto_combine was never added to it...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove old auto combine 592331420
607989892 https://github.com/pydata/xarray/pull/3926#issuecomment-607989892 https://api.github.com/repos/pydata/xarray/issues/3926 MDEyOklzc3VlQ29tbWVudDYwNzk4OTg5Mg== TomNicholas 35968931 2020-04-02T17:36:19Z 2020-04-02T17:36:39Z MEMBER

To make the docs CI pass

Thanks @keewis .

Shouldn't we change the FutureWarning to a DeprecationWarning before removing auto_combine?

I wasn't even aware that there were two types of warnings I could have used for this. I was taking "deprecating" to mean "removed" and "starting the deprecation cycle" to mean "start warning people it will soon be removed". The warning messages said "will no longer accept" and "will require" in "version 0.15" - that's probably authoritative enough isn't it?

There was a case I ran in to where the old auto_combine was needed and none of the newer options worked.

I think that was always a possible edge case - I would very much like to see it though @dcherian , if only so that we can put a "what to do if" section in the docs.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove old auto combine 592331420
607807193 https://github.com/pydata/xarray/pull/3926#issuecomment-607807193 https://api.github.com/repos/pydata/xarray/issues/3926 MDEyOklzc3VlQ29tbWVudDYwNzgwNzE5Mw== TomNicholas 35968931 2020-04-02T12:10:33Z 2020-04-02T12:10:33Z MEMBER

It would also be good to include any improvement to the relevant docs (e.g. #3830) in the same release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove old auto combine 592331420

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);