home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 607989892

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3926#issuecomment-607989892 https://api.github.com/repos/pydata/xarray/issues/3926 607989892 MDEyOklzc3VlQ29tbWVudDYwNzk4OTg5Mg== 35968931 2020-04-02T17:36:19Z 2020-04-02T17:36:39Z MEMBER

To make the docs CI pass

Thanks @keewis .

Shouldn't we change the FutureWarning to a DeprecationWarning before removing auto_combine?

I wasn't even aware that there were two types of warnings I could have used for this. I was taking "deprecating" to mean "removed" and "starting the deprecation cycle" to mean "start warning people it will soon be removed". The warning messages said "will no longer accept" and "will require" in "version 0.15" - that's probably authoritative enough isn't it?

There was a case I ran in to where the old auto_combine was needed and none of the newer options worked.

I think that was always a possible edge case - I would very much like to see it though @dcherian , if only so that we can put a "what to do if" section in the docs.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  592331420
Powered by Datasette · Queries took 0.928ms · About: xarray-datasette