issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 590630281 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • issues discovered by the all-but-dask CI · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1498756227 https://github.com/pydata/xarray/issues/3921#issuecomment-1498756227 https://api.github.com/repos/pydata/xarray/issues/3921 IC_kwDOAMm_X85ZVTSD keewis 14808389 2023-04-06T09:25:44Z 2023-04-06T09:25:58Z MEMBER

I think we'd need to be able to remove this xfail first: https://github.com/pydata/xarray/blob/f8127fc9ad24fe8b41cce9f891ab2c98eb2c679a/xarray/tests/test_backends.py#L712-L714 I didn't check, this could be xpassing right now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   issues discovered by the all-but-dask CI 590630281
606573918 https://github.com/pydata/xarray/issues/3921#issuecomment-606573918 https://api.github.com/repos/pydata/xarray/issues/3921 MDEyOklzc3VlQ29tbWVudDYwNjU3MzkxOA== keewis 14808389 2020-03-31T11:38:20Z 2020-03-31T11:54:00Z MEMBER

I think the lock is used to synchronize the I/O on the rasterio file, so we can't really remove it. The failing test states it is a regression test for #2121, but since then the backend code was rewritten. We'd probably need a serializable lock that does not depend on dask (I don't know much about the backend code, though)

Edit: we could vendor dask's SerializableLock, which basically wraps a threading.Lock but also makes sure to use the same lock after every pickle dumps/loads cycle.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   issues discovered by the all-but-dask CI 590630281
606339867 https://github.com/pydata/xarray/issues/3921#issuecomment-606339867 https://api.github.com/repos/pydata/xarray/issues/3921 MDEyOklzc3VlQ29tbWVudDYwNjMzOTg2Nw== max-sixty 5635139 2020-03-31T01:19:06Z 2020-03-31T01:19:06Z MEMBER

Great finds @keewis !

Any idea why a lock is being serialized at all with a Dataset?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   issues discovered by the all-but-dask CI 590630281

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);