issue_comments: 606573918

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3921#issuecomment-606573918 https://api.github.com/repos/pydata/xarray/issues/3921 606573918 MDEyOklzc3VlQ29tbWVudDYwNjU3MzkxOA== 14808389 2020-03-31T11:38:20Z 2020-03-31T11:54:00Z MEMBER

I think the lock is used to synchronize the I/O on the rasterio file, so we can't really remove it. The failing test states it is a regression test for #2121, but since then the backend code was rewritten. We'd probably need a serializable lock that does not depend on dask (I don't know much about the backend code, though)

Edit: we could vendor dask's SerializableLock, which basically wraps a threading.Lock but also makes sure to use the same lock after every pickle dumps/loads cycle.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   590630281