issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 572251686 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Allow chunk_store argument when opening Zarr datasets · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
680207098 https://github.com/pydata/xarray/pull/3804#issuecomment-680207098 https://api.github.com/repos/pydata/xarray/issues/3804 MDEyOklzc3VlQ29tbWVudDY4MDIwNzA5OA== dcherian 2448579 2020-08-25T18:49:45Z 2020-08-25T18:49:45Z MEMBER

Thanks for being patient @ajelenak I am excited to see this go in. welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow chunk_store argument when opening Zarr datasets 572251686
678354653 https://github.com/pydata/xarray/pull/3804#issuecomment-678354653 https://api.github.com/repos/pydata/xarray/issues/3804 MDEyOklzc3VlQ29tbWVudDY3ODM1NDY1Mw== dcherian 2448579 2020-08-21T15:35:30Z 2020-08-21T15:35:30Z MEMBER

Looks good to me. I will merge in a couple of days if no one else has any comments.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow chunk_store argument when opening Zarr datasets 572251686
649061398 https://github.com/pydata/xarray/pull/3804#issuecomment-649061398 https://api.github.com/repos/pydata/xarray/issues/3804 MDEyOklzc3VlQ29tbWVudDY0OTA2MTM5OA== dcherian 2448579 2020-06-24T20:44:25Z 2020-06-24T20:44:25Z MEMBER

It'd be nice to add some documentation to https://xarray.pydata.org/en/stable/io.html but that can happen in a future PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow chunk_store argument when opening Zarr datasets 572251686
649053064 https://github.com/pydata/xarray/pull/3804#issuecomment-649053064 https://api.github.com/repos/pydata/xarray/issues/3804 MDEyOklzc3VlQ29tbWVudDY0OTA1MzA2NA== rabernat 1197350 2020-06-24T20:27:56Z 2020-06-24T20:27:56Z MEMBER

Sorry for letting this hang so long. Now that https://github.com/zarr-developers/zarr-python/pull/557 has been merged and zarr 2.4.0 has been released, we should be able to finish this off.

The easiest thing would be to just require zarr > 2.4.0. However, we currently don't require zarr at all...it's an optional dependency. The code in this PR will fail for older versions of zarr. What's the best way to handle this? Having a bunch of internal checks for zarr versions feels clunky, but we've done it before.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow chunk_store argument when opening Zarr datasets 572251686
592097638 https://github.com/pydata/xarray/pull/3804#issuecomment-592097638 https://api.github.com/repos/pydata/xarray/issues/3804 MDEyOklzc3VlQ29tbWVudDU5MjA5NzYzOA== rabernat 1197350 2020-02-27T18:05:35Z 2020-03-02T14:40:30Z MEMBER

Fantastic, thanks @ajelenak so much for this contribution!

Two items come to mind: - [x] this will definitely need a test, just something simple to verify that the chunk_store argument works as expected - [ ] curious what will happen if you pass an actual Zarr storage object. I assume it will work fine, since these are all mutable mappings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow chunk_store argument when opening Zarr datasets 572251686

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);