home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 649053064

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3804#issuecomment-649053064 https://api.github.com/repos/pydata/xarray/issues/3804 649053064 MDEyOklzc3VlQ29tbWVudDY0OTA1MzA2NA== 1197350 2020-06-24T20:27:56Z 2020-06-24T20:27:56Z MEMBER

Sorry for letting this hang so long. Now that https://github.com/zarr-developers/zarr-python/pull/557 has been merged and zarr 2.4.0 has been released, we should be able to finish this off.

The easiest thing would be to just require zarr > 2.4.0. However, we currently don't require zarr at all...it's an optional dependency. The code in this PR will fail for older versions of zarr. What's the best way to handle this? Having a bunch of internal checks for zarr versions feels clunky, but we've done it before.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  572251686
Powered by Datasette · Queries took 400.37ms · About: xarray-datasette