issue_comments

Table actions

7 rows where author_association = "MEMBER", issue = 551680561 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • dcherian · 7 ✖

issue 1

  • Pint support for variables · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
590105084 https://github.com/pydata/xarray/pull/3706#issuecomment-590105084 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU5MDEwNTA4NA== dcherian 2448579 2020-02-23T19:13:03Z 2020-02-23T19:13:03Z MEMBER

Test failures look unrelated. Thanks @keewis 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561
582476396 https://github.com/pydata/xarray/pull/3706#issuecomment-582476396 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU4MjQ3NjM5Ng== dcherian 2448579 2020-02-05T15:57:10Z 2020-02-05T15:57:10Z MEMBER

let's mark these tests as xfail and discuss this in their own issues / PRs.

:+1: to smaller PRs!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561
578178685 https://github.com/pydata/xarray/pull/3706#issuecomment-578178685 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU3ODE3ODY4NQ== dcherian 2448579 2020-01-24T15:31:32Z 2020-01-24T15:31:32Z MEMBER

OK let's see what @shoyer thinks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561
577977929 https://github.com/pydata/xarray/pull/3706#issuecomment-577977929 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU3Nzk3NzkyOQ== dcherian 2448579 2020-01-24T03:34:04Z 2020-01-24T03:34:04Z MEMBER

I guess we need to either pass a kwarg regarding checking units/dimensionality down to lazy_array_equiv or add a units_equiv(only_dimensionality=True/False) check to https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/variable.py#L1645-L1648

I think a separate units_equiv function may be cleaner?

Note that we explicitly use lazy_array_equiv in concat so it'd be nice to have something that could be easily used there too: https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/concat.py#L194-L208

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561
577894139 https://github.com/pydata/xarray/pull/3706#issuecomment-577894139 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU3Nzg5NDEzOQ== dcherian 2448579 2020-01-23T21:51:52Z 2020-01-23T21:51:52Z MEMBER

re rolling_window: should I leave it as xfail for now?

Fine by me. :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561
577894064 https://github.com/pydata/xarray/pull/3706#issuecomment-577894064 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU3Nzg5NDA2NA== dcherian 2448579 2020-01-23T21:51:39Z 2020-01-23T21:51:39Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561
577885631 https://github.com/pydata/xarray/pull/3706#issuecomment-577885631 https://api.github.com/repos/pydata/xarray/issues/3706 MDEyOklzc3VlQ29tbWVudDU3Nzg4NTYzMQ== dcherian 2448579 2020-01-23T21:29:14Z 2020-01-23T21:29:14Z MEMBER

I think your units_equiv thing could go in duck_array_ops.lazy_array_equiv which tries to check everything but the actual values themselves.

but I don't know how to fix that unless we rewrite _rolling_window or dispatch differently in rolling_window.

This may be necessary but perhaps not the most important thing right now?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for variables 551680561

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);