issues: 551680561

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
551680561 MDExOlB1bGxSZXF1ZXN0MzY0MzU5NDky 3706 Pint support for variables 14808389 closed 0     24 2020-01-17T23:36:45Z 2020-02-24T00:09:54Z 2020-02-23T19:13:08Z MEMBER   0 pydata/xarray/pulls/3706

I realized that most of the operations depend on Variable, which means that this should be the first step to making the other tests pass. This PR copies from #3611, making that PR a work-in-progress again until I remove those parts.

  • [x] Closes #3783
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

These are the current failures: * np.prod: not implemented by pint yet, but should work once it is * comparisons: identical fails to detect same value, but in different units (like 1 m and 100 cm) as different. This is hard to implement in a way that does not include isinstance or hasattr checks. * rank: not implemented for non-ndarrays, so maybe we should mark this as skip? * rolling_window: nputils._rolling_window uses np.lib.stride_tricks.as_strided, which cannot be overridden by pint. We probably have to use something different? * shift: ~this tries to trim, then concatenate a filled array, but I think this should use np.pad after trimming? Are there any disadvantages to that?~ it uses numpy.pad now which is supported since dask==0.18 or dask==0.19 * concat: ~this was a misconception on my part, I didn't realize this was a classmethod. After fixing that this still fails because I assumed Variable.concat used the dimension names to reshape the arrays. It does not, so this fails:~ I rewrote the test to pass arrays that don't cause the failure python xr.Variable.concat([xr.Variable(("x", "y"), ...), xr.Variable(("y", "z"), ...)], dim="y") * pad_with_fill_value: ~I think this is a bug in pint (see hgrecco/pint#992)~ fixed on pint master

Does anyone have any comments on these before I start fixing them? @dcherian?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3706/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables