issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 544661257 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 2 ✖

issue 1

  • apply_ufunc: Add meta kwarg + bump dask to 2.2 · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
576794699 https://github.com/pydata/xarray/pull/3660#issuecomment-576794699 https://api.github.com/repos/pydata/xarray/issues/3660 MDEyOklzc3VlQ29tbWVudDU3Njc5NDY5OQ== shoyer 1217238 2020-01-21T17:37:45Z 2020-01-21T17:37:45Z MEMBER

OK great! Looks good to me!

On Tue, Jan 21, 2020 at 9:32 AM Deepak Cherian notifications@github.com wrote:

@dcherian commented on this pull request.

In xarray/tests/test_sparse.py https://github.com/pydata/xarray/pull/3660#discussion_r369142143:

@@ -873,3 +873,16 @@ def test_dask_token(): t5 = dask.base.tokenize(ac + 1) assert t4 != t5 assert isinstance(ac.data._meta, sparse.COO) + + +@requires_dask

There's a importorskip("sparse") on top so I think this is fine

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3660?email_source=notifications&email_token=AAJJFVVGGV56U62XNSJLVNTQ64WURA5CNFSM4KCEN2J2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSQHUMA#discussion_r369142143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVVWVJ2KZUF3NYURBM3Q64WURANCNFSM4KCEN2JQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc: Add meta kwarg + bump dask to 2.2 544661257
576117204 https://github.com/pydata/xarray/pull/3660#issuecomment-576117204 https://api.github.com/repos/pydata/xarray/issues/3660 MDEyOklzc3VlQ29tbWVudDU3NjExNzIwNA== shoyer 1217238 2020-01-20T05:49:33Z 2020-01-20T05:49:33Z MEMBER

This looks like an dask bug that we fixed a somewhat recently (6 months ago?).

I wouldn’t worry about it too much about it. Supporting old versions of dependencies is a best effort, not a mandate. I would just skip it on old versions of dask and move on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc: Add meta kwarg + bump dask to 2.2 544661257

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);