issue_comments: 576794699

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3660#issuecomment-576794699 https://api.github.com/repos/pydata/xarray/issues/3660 576794699 MDEyOklzc3VlQ29tbWVudDU3Njc5NDY5OQ== 1217238 2020-01-21T17:37:45Z 2020-01-21T17:37:45Z MEMBER

OK great! Looks good to me!

On Tue, Jan 21, 2020 at 9:32 AM Deepak Cherian notifications@github.com wrote:

@dcherian commented on this pull request.

In xarray/tests/test_sparse.py https://github.com/pydata/xarray/pull/3660#discussion_r369142143:

@@ -873,3 +873,16 @@ def test_dask_token(): t5 = dask.base.tokenize(ac + 1) assert t4 != t5 assert isinstance(ac.data._meta, sparse.COO) + + +@requires_dask

There's a importorskip("sparse") on top so I think this is fine

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3660?email_source=notifications&email_token=AAJJFVVGGV56U62XNSJLVNTQ64WURA5CNFSM4KCEN2J2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSQHUMA#discussion_r369142143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVVWVJ2KZUF3NYURBM3Q64WURANCNFSM4KCEN2JQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   544661257