issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 537576675 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
576116460 https://github.com/pydata/xarray/pull/3618#issuecomment-576116460 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3NjExNjQ2MA== shoyer 1217238 2020-01-20T05:46:09Z 2020-01-20T05:46:09Z MEMBER

This looks great, thanks for figuring this out!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
575689511 https://github.com/pydata/xarray/pull/3618#issuecomment-575689511 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3NTY4OTUxMQ== kmuehlbauer 5821660 2020-01-17T16:09:25Z 2020-01-17T16:09:25Z MEMBER

@dcherian Following up on #3702 it would be really great if this enhancement could make it into 0.15.0 If I can be of any further assistance please ping me. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
573820610 https://github.com/pydata/xarray/pull/3618#issuecomment-573820610 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3MzgyMDYxMA== kmuehlbauer 5821660 2020-01-13T19:07:01Z 2020-01-13T19:07:01Z MEMBER

Took the chance to rebase on latest master.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
573707411 https://github.com/pydata/xarray/pull/3618#issuecomment-573707411 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3MzcwNzQxMQ== kmuehlbauer 5821660 2020-01-13T15:05:53Z 2020-01-13T15:05:53Z MEMBER

@shoyer Please let me know if this needs rebasing after #3690 gets merged, or if I can anything do to finalize this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
573687432 https://github.com/pydata/xarray/pull/3618#issuecomment-573687432 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3MzY4NzQzMg== kmuehlbauer 5821660 2020-01-13T14:24:44Z 2020-01-13T14:24:44Z MEMBER

@shoyer I tried to address your review comments. I've added a temporary (backwards compatible) fix for #3680 to get along. Also using find_root_and_group to get hold of the filename is some kind of workaround until there is a better option.

I've added an item to whats-new.rst. For the API docs I did not find a fitting position because H5NetCDFStore and NetCDF4DataStore are nowhere mentioned there. So this might better be added in another PR by experienced xarray devs.

Unfortunately mypy checks are breaking due to some recent change (PR #3677).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
573678101 https://github.com/pydata/xarray/pull/3618#issuecomment-573678101 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3MzY3ODEwMQ== kmuehlbauer 5821660 2020-01-13T14:04:58Z 2020-01-13T14:17:53Z MEMBER

@TomNicholas After commit #1689db493f10262555196f658c52e370aacb4a33 (PR #3677) I get mypy TypCheck error:

xarray/core/dataset.py:3610: error: Item "Mapping[...]" of "Union[Dataset, Mapping[...]]" has no attribute "to_dataset"

Should I create an issue on that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
571457650 https://github.com/pydata/xarray/pull/3618#issuecomment-571457650 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU3MTQ1NzY1MA== kmuehlbauer 5821660 2020-01-07T06:40:16Z 2020-01-07T06:40:16Z MEMBER

Happy New Year to everyone especially at pydata.

I'd be happy to actively follow any reviews to sort things out and to get this addition pulled in. Many thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675
565706770 https://github.com/pydata/xarray/pull/3618#issuecomment-565706770 https://api.github.com/repos/pydata/xarray/issues/3618 MDEyOklzc3VlQ29tbWVudDU2NTcwNjc3MA== kmuehlbauer 5821660 2019-12-14T10:57:28Z 2019-12-14T10:57:28Z MEMBER

I'm unsure how this should be referenced in the docs/news because the netCDF4 counterpart doesn't have any mention about that feature too.

It seems that everything runs smoothly, the one error looks like it is unrelated. Please let me know, if the added test is enough and if you want me to do anything else. I'll leave the WIP mark in place so far.

Ping @shoyer, he might see if there are immediate problems with the code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… 537576675

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);