issue_comments: 573687432

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3618#issuecomment-573687432 https://api.github.com/repos/pydata/xarray/issues/3618 573687432 MDEyOklzc3VlQ29tbWVudDU3MzY4NzQzMg== 5821660 2020-01-13T14:24:44Z 2020-01-13T14:24:44Z MEMBER

@shoyer I tried to address your review comments. I've added a temporary (backwards compatible) fix for #3680 to get along. Also using find_root_and_group to get hold of the filename is some kind of workaround until there is a better option.

I've added an item to whats-new.rst. For the API docs I did not find a fitting position because H5NetCDFStore and NetCDF4DataStore are nowhere mentioned there. So this might better be added in another PR by experienced xarray devs.

Unfortunately mypy checks are breaking due to some recent change (PR #3677).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   537576675