issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 514529201 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Error in leap year? · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
548368734 https://github.com/pydata/xarray/pull/3464#issuecomment-548368734 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0ODM2ODczNA== keewis 14808389 2019-10-31T13:15:15Z 2019-10-31T13:15:15Z MEMBER

deleting won't affect this PR, so I'd say you are free to do what you want with your repository

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547988237 https://github.com/pydata/xarray/pull/3464#issuecomment-547988237 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0Nzk4ODIzNw== max-sixty 5635139 2019-10-30T16:16:42Z 2019-10-30T16:16:42Z MEMBER

Thanks @mickaellalande !

And @keewis for the mentoring!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547944494 https://github.com/pydata/xarray/pull/3464#issuecomment-547944494 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0Nzk0NDQ5NA== dcherian 2448579 2019-10-30T14:51:21Z 2019-10-30T14:51:21Z MEMBER

Great. Thanks @mickaellalande . Welcome to xarray!

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547918057 https://github.com/pydata/xarray/pull/3464#issuecomment-547918057 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0NzkxODA1Nw== keewis 14808389 2019-10-30T14:00:36Z 2019-10-30T14:00:36Z MEMBER

that did it. @max-sixty, what do you think?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547914828 https://github.com/pydata/xarray/pull/3464#issuecomment-547914828 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0NzkxNDgyOA== keewis 14808389 2019-10-30T13:54:11Z 2019-10-30T13:54:11Z MEMBER

yeah, you pushed to master on your own repository, but you should do that for patch-1

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547912025 https://github.com/pydata/xarray/pull/3464#issuecomment-547912025 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0NzkxMjAyNQ== keewis 14808389 2019-10-30T13:48:31Z 2019-10-30T13:52:43Z MEMBER

this looks good to me, but I don't see your commit changing whats-new.rst. Did you push that commit?

Ignore the failure on windows, that is unrelated to this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547900193 https://github.com/pydata/xarray/pull/3464#issuecomment-547900193 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0NzkwMDE5Mw== keewis 14808389 2019-10-30T13:23:41Z 2019-10-30T13:23:41Z MEMBER

Everyone has to start somewhere :)

To change the base, see here. Also, now that @max-sixty added some commits, you will probably have to git pull once before adding more changes yourself (otherwise it complains that the remote has different commits).

$repository/doc/whats-new.rst is a file where all the changes are listed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201
547882241 https://github.com/pydata/xarray/pull/3464#issuecomment-547882241 https://api.github.com/repos/pydata/xarray/issues/3464 MDEyOklzc3VlQ29tbWVudDU0Nzg4MjI0MQ== max-sixty 5635139 2019-10-30T12:41:04Z 2019-10-30T12:41:04Z MEMBER

Hi @mickaellalande — thanks for the PR, happy to have you as an xarray contributor!

I think you're right.

I guess we don't have tests for these...

@mickaellalande because our docs branch (stable) is a bit behind master, tests are failing. I pushed a change to your code that branched off master. Could you please change the 'base' of your PR to master? Let me know if that's unclear.

Could you also add a change & your name to whatsnew?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error in leap year? 514529201

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);