issue_comments: 547882241

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3464#issuecomment-547882241 https://api.github.com/repos/pydata/xarray/issues/3464 547882241 MDEyOklzc3VlQ29tbWVudDU0Nzg4MjI0MQ== 5635139 2019-10-30T12:41:04Z 2019-10-30T12:41:04Z MEMBER

Hi @mickaellalande — thanks for the PR, happy to have you as an xarray contributor!

I think you're right.

I guess we don't have tests for these...

@mickaellalande because our docs branch (stable) is a bit behind master, tests are failing. I pushed a change to your code that branched off master. Could you please change the 'base' of your PR to master? Let me know if that's unclear.

Could you also add a change & your name to whatsnew?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   514529201