issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 484270833 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • combine_by_coords fails with DataArrays · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
531825386 https://github.com/pydata/xarray/issues/3248#issuecomment-531825386 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDUzMTgyNTM4Ng== dcherian 2448579 2019-09-16T15:19:50Z 2019-09-16T15:20:59Z MEMBER

Thanks @friedrichknuth .

It looks like all the combine functions expect lists of Datasets, not DataArrays (see docstrings).

It should be relatively easily to make this work like merge which can take a list of Datasets or DataArrays. See this code in merge: https://github.com/pydata/xarray/blob/756c94164840e8c070bcd26681b97c31412909ae/xarray/core/merge.py#L593-L602

to_dataset will fail for unnamed DataArrays, but _to_temp_dataset() will succeed. It seems to me like we want lists of unnamed DataArrays to work (like in the first example), so call _to_temp_dataset when needed. Maybe @shoyer has an idea on how to implement that cleanly.

Can you send in a PR?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833
526263925 https://github.com/pydata/xarray/issues/3248#issuecomment-526263925 https://api.github.com/repos/pydata/xarray/issues/3248 MDEyOklzc3VlQ29tbWVudDUyNjI2MzkyNQ== dcherian 2448579 2019-08-29T16:31:41Z 2019-08-29T16:31:41Z MEMBER

What do you think of:

  1. If combine receives a list of unnamed DataArrays, we convert them to temp datasets and then pass datasets down to merge.

  2. If combine receives a list of named DataArrays, then merge will do the right thing.

  3. If combine receives a list containing both Datasets and unnamed DataArrays then merge will raise the right error.

So really it's just (1) that needs a special case in the combine functions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine_by_coords fails with DataArrays 484270833

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);