issue_comments

Table actions

12 rows where author_association = "MEMBER" and issue = 467865659 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Support keyword API for `Dataset.drop` · 12 ✖

author_association 1

  • MEMBER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
522387948 https://github.com/pydata/xarray/pull/3128#issuecomment-522387948 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjM4Nzk0OA== max-sixty 5635139 2019-08-19T02:24:00Z 2019-08-19T02:24:00Z MEMBER

I think the easiest way forward is to do a follow-up PR, no need to revert.

Reverting would be helpful if we wanted to undo these changes - in this case we have some v marginal additional changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522359045 https://github.com/pydata/xarray/pull/3128#issuecomment-522359045 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjM1OTA0NQ== shoyer 1217238 2019-08-18T21:53:08Z 2019-08-18T21:53:08Z MEMBER

My (limited) understanding of how github handles reverting is that you'll still need to make a new pull request to apply your edits either way. There is no more going to back to amend after PR is merges. The only difference is what the state of "master" looks like when you make your new pull request (whether it includes your partial changes or not).

So I don't think it particularly matters if you revert first (as long as the forward fix happens relatively soon), but if you'd prefer to do it that way that's totally fine -- let me know and I will do it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522354720 https://github.com/pydata/xarray/pull/3128#issuecomment-522354720 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjM1NDcyMA== shoyer 1217238 2019-08-18T20:56:29Z 2019-08-18T20:56:29Z MEMBER

Post merge reviews are totally fine. It is not a big deal to revert a merge if needed.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522353874 https://github.com/pydata/xarray/pull/3128#issuecomment-522353874 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjM1Mzg3NA== max-sixty 5635139 2019-08-18T20:43:55Z 2019-08-18T20:43:55Z MEMBER

@shoyer thanks for the follow-up comments. I probably should have spotted those myself. But given there'll be points I miss, lmk if I should be waiting longer / raising specific points before hitting the big green button, or these post-merge reviews are OK. I can ensure they're complete before a release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522341108 https://github.com/pydata/xarray/pull/3128#issuecomment-522341108 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjM0MTEwOA== max-sixty 5635139 2019-08-18T17:42:54Z 2019-08-18T17:42:54Z MEMBER

Great @gwgundersen !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522278593 https://github.com/pydata/xarray/pull/3128#issuecomment-522278593 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjI3ODU5Mw== max-sixty 5635139 2019-08-17T23:43:20Z 2019-08-17T23:43:20Z MEMBER

@gwgundersen could we add a whatsnew too?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522248198 https://github.com/pydata/xarray/pull/3128#issuecomment-522248198 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjI0ODE5OA== max-sixty 5635139 2019-08-17T15:42:10Z 2019-08-17T15:42:10Z MEMBER

I see the docs timing out after 60 min. I also see that message, but is that causing the failure?

I restarted the docs build to see whether that might help

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522241417 https://github.com/pydata/xarray/pull/3128#issuecomment-522241417 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjI0MTQxNw== dcherian 2448579 2019-08-17T14:21:27Z 2019-08-17T14:21:27Z MEMBER

It looks like you've added a warming for this case. So you'll need to specify :okwarning: . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522057416 https://github.com/pydata/xarray/pull/3128#issuecomment-522057416 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjA1NzQxNg== max-sixty 5635139 2019-08-16T15:50:06Z 2019-08-16T15:50:06Z MEMBER

Thanks @gwgundersen - good idea re the cherry pick for more discrete changes.

Still getting a test failure though, check it out and lmk if you need any help

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
521828045 https://github.com/pydata/xarray/pull/3128#issuecomment-521828045 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMTgyODA0NQ== max-sixty 5635139 2019-08-15T23:08:42Z 2019-08-15T23:08:42Z MEMBER

@gwgundersen Could you force-push your latest code?

If your current latest code is pushed, you may have to git reset --hard and start again - unfortunately it looks like your PR is proposing +24,439 −17,647 changes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
521818408 https://github.com/pydata/xarray/pull/3128#issuecomment-521818408 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMTgxODQwOA== max-sixty 5635139 2019-08-15T22:23:07Z 2019-08-15T22:23:07Z MEMBER

@gwgundersen I see you trying to merge re the recent black changes. Here are the instructions for making this (relatively) seamless: https://github.com/pydata/xarray/blob/d3f1ced1aa84cb0a0f3e47e7ee67492e203fcce5/doc/contributing.rst#code-formatting

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
511229790 https://github.com/pydata/xarray/pull/3128#issuecomment-511229790 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUxMTIyOTc5MA== shoyer 1217238 2019-07-14T19:41:38Z 2019-07-14T19:41:38Z MEMBER

Awesome, thanks for working on this @gwgundersen !

In the long term, we might want to deprecate the current function signature, but I'm happy to leave that for later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);