issue_comments: 522359045
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3128#issuecomment-522359045 | https://api.github.com/repos/pydata/xarray/issues/3128 | 522359045 | MDEyOklzc3VlQ29tbWVudDUyMjM1OTA0NQ== | 1217238 | 2019-08-18T21:53:08Z | 2019-08-18T21:53:08Z | MEMBER | My (limited) understanding of how github handles reverting is that you'll still need to make a new pull request to apply your edits either way. There is no more going to back to amend after PR is merges. The only difference is what the state of "master" looks like when you make your new pull request (whether it includes your partial changes or not). So I don't think it particularly matters if you revert first (as long as the forward fix happens relatively soon), but if you'd prefer to do it that way that's totally fine -- let me know and I will do it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
467865659 |