issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 467856527 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Return immutable view of Pandas indexes · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
512058648 https://github.com/pydata/xarray/pull/3126#issuecomment-512058648 https://api.github.com/repos/pydata/xarray/issues/3126 MDEyOklzc3VlQ29tbWVudDUxMjA1ODY0OA== max-sixty 5635139 2019-07-17T00:56:58Z 2019-07-17T00:56:58Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Return immutable view of Pandas indexes 467856527
512027994 https://github.com/pydata/xarray/pull/3126#issuecomment-512027994 https://api.github.com/repos/pydata/xarray/issues/3126 MDEyOklzc3VlQ29tbWVudDUxMjAyNzk5NA== max-sixty 5635139 2019-07-16T22:36:51Z 2019-07-16T22:36:51Z MEMBER

Do we want all views of indexes to be immutable or do we trust the user to not do stuff like this:

Is there a reasonable way of making that immutable? Given that the index allows its name to be mutated, I'm not sure.

(we can also separate that issue from this change, which is already 👍 )

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Return immutable view of Pandas indexes 467856527
511523854 https://github.com/pydata/xarray/pull/3126#issuecomment-511523854 https://api.github.com/repos/pydata/xarray/issues/3126 MDEyOklzc3VlQ29tbWVudDUxMTUyMzg1NA== max-sixty 5635139 2019-07-15T18:48:26Z 2019-07-15T18:48:26Z MEMBER

It looks like to_series calls to_index, which calls get_index,

Thanks for finding that. That sounds right - if we make these changes there then I think we've solved the problem at its root and we should fix all these cases?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Return immutable view of Pandas indexes 467856527
511451574 https://github.com/pydata/xarray/pull/3126#issuecomment-511451574 https://api.github.com/repos/pydata/xarray/issues/3126 MDEyOklzc3VlQ29tbWVudDUxMTQ1MTU3NA== max-sixty 5635139 2019-07-15T15:32:09Z 2019-07-15T15:32:09Z MEMBER

I don't quite understand why the previous constructor was returning a mutable view, but the tests look great.

@gwgundersen do you know if we should instead be changing the to_index method which the to_series calls?

Any other comments from anyone?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Return immutable view of Pandas indexes 467856527

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);