issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 460562436 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date)

user 1

  • max-sixty · 5 ✖

issue 1

  • Added rename_coords and rename_dims · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505645069 https://github.com/pydata/xarray/pull/3042#issuecomment-505645069 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTY0NTA2OQ== max-sixty 5635139 2019-06-25T22:22:59Z 2019-06-25T22:22:59Z MEMBER

@jukent I don't think that's our bot

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505621145 https://github.com/pydata/xarray/pull/3042#issuecomment-505621145 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTYyMTE0NQ== max-sixty 5635139 2019-06-25T21:01:22Z 2019-06-25T21:01:22Z MEMBER

Those look great!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505604339 https://github.com/pydata/xarray/pull/3042#issuecomment-505604339 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTYwNDMzOQ== max-sixty 5635139 2019-06-25T20:13:25Z 2019-06-25T20:13:25Z MEMBER

@jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130

You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result.

Ping back with any issues

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505596702 https://github.com/pydata/xarray/pull/3042#issuecomment-505596702 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTU5NjcwMg== max-sixty 5635139 2019-06-25T19:51:09Z 2019-06-25T19:51:09Z MEMBER

And tbc, we should add tests here. That will help clarify the issues above re exactly which items on the dataset each method should rename vs leave.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505594770 https://github.com/pydata/xarray/pull/3042#issuecomment-505594770 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTU5NDc3MA== max-sixty 5635139 2019-06-25T19:45:53Z 2019-06-25T19:45:53Z MEMBER

This is great! Thanks @jukent ! Ping back here if there's anything we can do to help

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);