issue_comments: 505604339
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3042#issuecomment-505604339 | https://api.github.com/repos/pydata/xarray/issues/3042 | 505604339 | MDEyOklzc3VlQ29tbWVudDUwNTYwNDMzOQ== | 5635139 | 2019-06-25T20:13:25Z | 2019-06-25T20:13:25Z | MEMBER | @jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130 You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result. Ping back with any issues |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
460562436 |