issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 453964049 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Fix 'to_masked_array' computing dask arrays twice · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505531367 https://github.com/pydata/xarray/pull/3006#issuecomment-505531367 https://api.github.com/repos/pydata/xarray/issues/3006 MDEyOklzc3VlQ29tbWVudDUwNTUzMTM2Nw== shoyer 1217238 2019-06-25T16:56:19Z 2019-06-25T16:56:19Z MEMBER

hopefully out this week! I am going to wait another day or two for someone else to look at https://github.com/pydata/xarray/pull/3040/ and then will probably be issuing a release.

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix 'to_masked_array' computing dask arrays twice 453964049
500411377 https://github.com/pydata/xarray/pull/3006#issuecomment-500411377 https://api.github.com/repos/pydata/xarray/issues/3006 MDEyOklzc3VlQ29tbWVudDUwMDQxMTM3Nw== shoyer 1217238 2019-06-10T13:12:37Z 2019-06-10T13:12:37Z MEMBER

@djhoese It looks like something broke in the development version of dask. But that shouldn't hold up merging your fix here...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix 'to_masked_array' computing dask arrays twice 453964049
500290315 https://github.com/pydata/xarray/pull/3006#issuecomment-500290315 https://api.github.com/repos/pydata/xarray/issues/3006 MDEyOklzc3VlQ29tbWVudDUwMDI5MDMxNQ== shoyer 1217238 2019-06-10T04:46:57Z 2019-06-10T04:46:57Z MEMBER

I'd be happy to merge this fix. I think it's a vestige of when we used to always cached computations.

I'd also love to have more comprehensive test coverage, and I like the look of your custom scheduler. But I'm not sure it's worth adding that many lines of test logic for what is essentially a one line fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix 'to_masked_array' computing dask arrays twice 453964049

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);