home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 500290315

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3006#issuecomment-500290315 https://api.github.com/repos/pydata/xarray/issues/3006 500290315 MDEyOklzc3VlQ29tbWVudDUwMDI5MDMxNQ== 1217238 2019-06-10T04:46:57Z 2019-06-10T04:46:57Z MEMBER

I'd be happy to merge this fix. I think it's a vestige of when we used to always cached computations.

I'd also love to have more comprehensive test coverage, and I like the look of your custom scheduler. But I'm not sure it's worth adding that many lines of test logic for what is essentially a one line fix.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  453964049
Powered by Datasette · Queries took 0.66ms · About: xarray-datasette