issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 434502234 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • keewis · 2 ✖

issue 1

  • Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
781406357 https://github.com/pydata/xarray/pull/2905#issuecomment-781406357 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDc4MTQwNjM1Nw== keewis 14808389 2021-02-18T15:04:02Z 2021-02-18T15:04:02Z MEMBER

thanks again, @blsqr

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
780909179 https://github.com/pydata/xarray/pull/2905#issuecomment-780909179 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDc4MDkwOTE3OQ== keewis 14808389 2021-02-17T22:56:29Z 2021-02-17T22:56:29Z MEMBER

@blsqr, I'm sorry for taking so long to review this. I updated your PR so this should be ready for merging.

I'm not sure that Variable is wrapping this CustomValues thing properly though.

that turned out not to be true, we can't wrap it in a list because then as_compatible_data wouldn't be able to find .values. Instead, Variable(dims=(), data=array) (or converting it to a duckarray) is the way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);