issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 412645481 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • enable loading remote hdf5 files · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
473481213 https://github.com/pydata/xarray/pull/2782#issuecomment-473481213 https://api.github.com/repos/pydata/xarray/issues/2782 MDEyOklzc3VlQ29tbWVudDQ3MzQ4MTIxMw== shoyer 1217238 2019-03-16T00:36:12Z 2019-03-16T00:36:12Z MEMBER

thanks @scottyhq !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   enable loading remote hdf5 files 412645481
469941846 https://github.com/pydata/xarray/pull/2782#issuecomment-469941846 https://api.github.com/repos/pydata/xarray/issues/2782 MDEyOklzc3VlQ29tbWVudDQ2OTk0MTg0Ng== shoyer 1217238 2019-03-06T02:27:49Z 2019-03-06T02:27:49Z MEMBER

I don't think it's essential to have an integration test doing real network access in xarray, so I would consider just dropping that part instead.

On Tue, Mar 5, 2019 at 6:10 PM Ryan Abernathey notifications@github.com wrote:

@rabernat commented on this pull request.

In xarray/tests/test_backends.py https://github.com/pydata/xarray/pull/2782#discussion_r262767473:

@@ -1955,6 +1955,39 @@ def test_dump_encodings_h5py(self): assert actual.x.encoding['compression_opts'] is None

+@requires_h5fileobj +class TestH5NetCDFFileObject(TestH5NetCDFData): + h5py = pytest.importorskip('h5py', minversion='2.9.0') + engine = 'h5netcdf' + + @network + def test_h5remote(self): + # alternative: http://era5-pds.s3.amazonaws.com/2008/01/main.nc

Rather than going over the network, it might be quite easy to fire up a http.server.SimpleHTTPRequestHandler https://docs.python.org/3/library/http.server.html#http.server.SimpleHTTPRequestHandler as part of a fixture. This would allow us to test the remote capability without internet (and without depending on a third party to host a file.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2782#pullrequestreview-211014423, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1puGwIDrvG3NGvfq5oXqwdtbHSIDks5vTyOkgaJpZM4bGMFq . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   enable loading remote hdf5 files 412645481
466260533 https://github.com/pydata/xarray/pull/2782#issuecomment-466260533 https://api.github.com/repos/pydata/xarray/issues/2782 MDEyOklzc3VlQ29tbWVudDQ2NjI2MDUzMw== shoyer 1217238 2019-02-22T03:27:56Z 2019-02-22T03:27:56Z MEMBER

This looks great!

I'll note one minor extension: you could look at the first few bytes of the file (the "magic number") to determine if it's a netCDF3 or netCDF4 file, and hence whether it can be opened with scipy or h5netcdf:

  • CDF\001 or CDF\002 would indicate netCDF3 (use scipy)
  • \211HDF\r\n\032\n would indicate netCDF4/HDF5 (use h5netcdf)
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   enable loading remote hdf5 files 412645481

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);