issue_comments: 469941846

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2782#issuecomment-469941846 https://api.github.com/repos/pydata/xarray/issues/2782 469941846 MDEyOklzc3VlQ29tbWVudDQ2OTk0MTg0Ng== 1217238 2019-03-06T02:27:49Z 2019-03-06T02:27:49Z MEMBER

I don't think it's essential to have an integration test doing real network access in xarray, so I would consider just dropping that part instead.

On Tue, Mar 5, 2019 at 6:10 PM Ryan Abernathey notifications@github.com wrote:

@rabernat commented on this pull request.

In xarray/tests/test_backends.py https://github.com/pydata/xarray/pull/2782#discussion_r262767473:

@@ -1955,6 +1955,39 @@ def test_dump_encodings_h5py(self): assert actual.x.encoding['compression_opts'] is None

+@requires_h5fileobj +class TestH5NetCDFFileObject(TestH5NetCDFData): + h5py = pytest.importorskip('h5py', minversion='2.9.0') + engine = 'h5netcdf' + + @network + def test_h5remote(self): + # alternative: http://era5-pds.s3.amazonaws.com/2008/01/main.nc

Rather than going over the network, it might be quite easy to fire up a http.server.SimpleHTTPRequestHandler https://docs.python.org/3/library/http.server.html#http.server.SimpleHTTPRequestHandler as part of a fixture. This would allow us to test the remote capability without internet (and without depending on a third party to host a file.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2782#pullrequestreview-211014423, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1puGwIDrvG3NGvfq5oXqwdtbHSIDks5vTyOkgaJpZM4bGMFq . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   412645481