issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 398468139 and user = 6628425 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • spencerkclark · 4 ✖

issue 1

  • fix datetime_to_numeric and Variable._to_numeric · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
462303166 https://github.com/pydata/xarray/pull/2668#issuecomment-462303166 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ2MjMwMzE2Ng== spencerkclark 6628425 2019-02-11T11:58:22Z 2019-02-11T11:58:22Z MEMBER

Thanks for wrapping this up @fujiisoup!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
462134943 https://github.com/pydata/xarray/pull/2668#issuecomment-462134943 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ2MjEzNDk0Mw== spencerkclark 6628425 2019-02-10T13:55:55Z 2019-02-10T13:55:55Z MEMBER

As I'm not a heavy user of datetime arrays, I personally do not mind if we do not have dask compatibility for datetime_to_numeric.

No worries @fujiisoup, this is totally fine with me. I think the most common use case for datetime arrays is in indexes, which currently need to be stored in memory anyway, so I don't think the dask use case would come up very often.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453874778 https://github.com/pydata/xarray/pull/2668#issuecomment-453874778 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1Mzg3NDc3OA== spencerkclark 6628425 2019-01-13T23:14:00Z 2019-01-13T23:14:00Z MEMBER

It looks I need more work for this (probably a week). It is not working for cftime stuffs, but I do not yet understand how it is handled in xarray.

Thanks @fujiisoup, no worries. There was only one place where I saw a potential issue for cftime dates, which I noted above. I made a PR to your branch with the fix (https://github.com/fujiisoup/xarray/pull/9); let me know if there were other places with issues and I can sort those out too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139
453679270 https://github.com/pydata/xarray/pull/2668#issuecomment-453679270 https://api.github.com/repos/pydata/xarray/issues/2668 MDEyOklzc3VlQ29tbWVudDQ1MzY3OTI3MA== spencerkclark 6628425 2019-01-11T22:37:06Z 2019-01-11T22:37:06Z MEMBER

what convention do you use for missing values in cftime arrays?

Currently there is nothing built in to xarray to support missing values for cftime arrays. I think we would have to come up with a convention.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix datetime_to_numeric and Variable._to_numeric 398468139

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);